[
https://issues.apache.org/jira/browse/HIVE-26200?focusedWorklogId=766684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766684
]
ASF GitHub Bot logged work on HIVE-26200:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/22 14:12
Start Date: 05/May/22 14:12
Worklog Time Spent: 10m
Work Description: lcspinter commented on code in PR #3268:
URL: https://github.com/apache/hive/pull/3268#discussion_r865950953
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergV2.java:
##########
@@ -354,6 +356,30 @@ public void
testDeleteStatementWithPartitionAndSchemaEvolution() {
HiveIcebergTestUtils.validateData(expected,
HiveIcebergTestUtils.valueForRow(newSchema, objects), 0);
}
+ @Test
+ public void testDeleteForSupportedTypes() throws IOException {
+ for (int i = 0; i < SUPPORTED_TYPES.size(); i++) {
+ Type type = SUPPORTED_TYPES.get(i);
+ // TODO: remove this filter when issue #1881 is resolved
+ if (type == Types.UUIDType.get() && fileFormat == FileFormat.PARQUET) {
+ continue;
+ }
+ // TODO: remove this filter when we figure out how we could test binary
types
+ if (type.equals(Types.BinaryType.get()) ||
type.equals(Types.FixedType.ofLength(5))) {
Review Comment:
nit: == instead of equals, just to follow the pattern
Issue Time Tracking
-------------------
Worklog Id: (was: 766684)
Time Spent: 20m (was: 10m)
> Add tests for Iceberg DELETE statements for every supported type
> ----------------------------------------------------------------
>
> Key: HIVE-26200
> URL: https://issues.apache.org/jira/browse/HIVE-26200
> Project: Hive
> Issue Type: Test
> Reporter: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It would be good to check if we are able to delete every supported column
> type.
> I have found issues with updates, and I think it would be good to have
> additional tests with delete as well (even though they are working correctly
> ATM)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
