[
https://issues.apache.org/jira/browse/HIVE-26071?focusedWorklogId=766929&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766929
]
ASF GitHub Bot logged work on HIVE-26071:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/22 21:11
Start Date: 05/May/22 21:11
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3233:
URL: https://github.com/apache/hive/pull/3233#discussion_r866317420
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HmsThriftHttpServlet.java:
##########
@@ -39,75 +48,119 @@ public class HmsThriftHttpServlet extends TServlet {
.getLogger(HmsThriftHttpServlet.class);
private static final String X_USER = MetaStoreUtils.USER_NAME_HTTP_HEADER;
-
private final boolean isSecurityEnabled;
+ private final boolean jwtAuthEnabled;
+ public static final String AUTHORIZATION = "Authorization";
+ private JWTValidator jwtValidator;
+ private Configuration conf;
public HmsThriftHttpServlet(TProcessor processor,
- TProtocolFactory inProtocolFactory, TProtocolFactory outProtocolFactory)
{
- super(processor, inProtocolFactory, outProtocolFactory);
- // This should ideally be reveiving an instance of the Configuration which
is used for the check
+ TProtocolFactory protocolFactory, Configuration conf) {
Review Comment:
@sourabh912 - I didn't know that this class was recently introduced in the
thrift over http patch. In that case, it would be ideal to leave this as such
with the existing constructor. We can always do constructor overloading in the
future if any use case arises.
Issue Time Tracking
-------------------
Worklog Id: (was: 766929)
Time Spent: 6h 10m (was: 6h)
> JWT authentication for Thrift over HTTP in HiveMetaStore
> --------------------------------------------------------
>
> Key: HIVE-26071
> URL: https://issues.apache.org/jira/browse/HIVE-26071
> Project: Hive
> Issue Type: New Feature
> Components: Standalone Metastore
> Reporter: Sourabh Goyal
> Assignee: Sourabh Goyal
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> HIVE-25575 recently added a support for JWT authentication in HS2. This Jira
> aims to add the same feature in HMS
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
