[
https://issues.apache.org/jira/browse/HIVE-26202?focusedWorklogId=768509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768509
]
ASF GitHub Bot logged work on HIVE-26202:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/22 13:45
Start Date: 10/May/22 13:45
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3269:
URL: https://github.com/apache/hive/pull/3269#discussion_r869259245
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -571,6 +571,15 @@ public static boolean isUpdate(Configuration conf, String
tableName) {
conf.get(InputFormatConfig.OPERATION_TYPE_PREFIX + tableName));
}
+ public static Operation operation(Configuration conf, String tableName) {
Review Comment:
I was reluctant to do so, because then we will do an unnecessary conversion
(string -> enum), but we could do this if we think the code is better - maybe
even remove the methods and use equals for the operation instead.
Issue Time Tracking
-------------------
Worklog Id: (was: 768509)
Time Spent: 0.5h (was: 20m)
> Refactor Iceberg Writers
> ------------------------
>
> Key: HIVE-26202
> URL: https://issues.apache.org/jira/browse/HIVE-26202
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
