[
https://issues.apache.org/jira/browse/HIVE-26145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534398#comment-17534398
]
Stamatis Zampetakis commented on HIVE-26145:
--------------------------------------------
Thanks for taking the time to address my comments [~kovjanos].
I am afraid that the changes proposed in the PR make the code more difficult to
follow and there is a risk of breaking something.
Personally, I would leave things as they are i.e., use
{{metastore.event.db.listener.clean.startup.wait.interval}} for turning off the
cleaner. A way to make things more formal would be to update the description of
{{metastore.event.db.listener.clean.startup.wait.interval}} property to
indicate that setting it to a big value somewhat disables the cleaner.
Still this is a personal preference (and subjective) so if there are others who
prefer another option from those that [~kovjanos] outlined previously I am not
going to stand in the middle.
> Disable notification cleaner if interval is zero
> ------------------------------------------------
>
> Key: HIVE-26145
> URL: https://issues.apache.org/jira/browse/HIVE-26145
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
> Reporter: Janos Kovacs
> Assignee: Janos Kovacs
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Many of the housekeeping/background tasks can be turned off in case of having
> multiple instances running parallel.
> Some are controlled via the housekeeping node configuration, others are not
> started if their frequency is set to zero.
> The DB-Notification cleaner unfortunately doesn't have this functionality
> which makes all instances to race for the lock on the backend HMS database.
> Goal is to add change to be able to turn cleaner off in case if there are
> multiple instances running (be able to bound it to the housekeeping
> instance).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
