[
https://issues.apache.org/jira/browse/HIVE-26203?focusedWorklogId=768879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-768879
]
ASF GitHub Bot logged work on HIVE-26203:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 08:00
Start Date: 11/May/22 08:00
Worklog Time Spent: 10m
Work Description: lcspinter commented on code in PR #3270:
URL: https://github.com/apache/hive/pull/3270#discussion_r869991050
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java:
##########
@@ -1456,6 +1456,63 @@ public void testCreateTableWithMetadataLocation() throws
IOException {
HiveIcebergStorageHandlerTestUtils.CUSTOMER_RECORDS.stream()).collect(Collectors.toList()),
records, 0);
}
+ @Test
+ public void testAlterTableWithMetadataLocation() throws IOException {
+ Assume.assumeTrue("Alter table with metadata location is only supported
for Hive Catalog tables",
Review Comment:
I'm not sure this is inconsistent. The HMS table property
`metadata_location` has a special meaning if the table belongs to the hive
catalog. It is also treated differently in our `HiveTableOperations` class,
refreshing the metadata based on the value of this property.
In the case of tables from other catalog types, this is just a regular table
property and it doesn't have any highlighted meaning. So I run an alter query I
would expect that the table property is changed but nothing else.
Issue Time Tracking
-------------------
Worklog Id: (was: 768879)
Time Spent: 2h (was: 1h 50m)
> Implement alter iceberg table metadata location
> -----------------------------------------------
>
> Key: HIVE-26203
> URL: https://issues.apache.org/jira/browse/HIVE-26203
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: iceberg, pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
