[
https://issues.apache.org/jira/browse/HIVE-26191?focusedWorklogId=769181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769181
]
ASF GitHub Bot logged work on HIVE-26191:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 16:26
Start Date: 11/May/22 16:26
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on code in PR #3280:
URL: https://github.com/apache/hive/pull/3280#discussion_r870520711
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java:
##########
@@ -2506,13 +2506,13 @@ private Map<Object, Object> getQueryCache() {
}
@Override
- protected String getValidWriteIdList(String dbName, String tblName) {
+ protected String getValidWriteIdList(String catName, String dbName, String
tblName) {
Review Comment:
an alternate approach would be to replace arguments like this with a
`TableName`...so that we move forward with that refactor and use that object
more extensively;
I think bugs like this are simply just sideeffects of passing a set of
strings together - and sometimes miss one...
Issue Time Tracking
-------------------
Worklog Id: (was: 769181)
Time Spent: 20m (was: 10m)
> Missing catalog name in GetTableRequest results in duplicate values in query
> level cache
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-26191
> URL: https://issues.apache.org/jira/browse/HIVE-26191
> Project: Hive
> Issue Type: Bug
> Reporter: Soumyakanti Das
> Assignee: Soumyakanti Das
> Priority: Major
> Labels: pull-request-available
> Attachments: query_cache.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{getTableInternal}} method in {{SessionHiveMetaStoreClient}} accepts a
> {{GetTableRequest}} object with a {{null}} value for catalog. Because of this
> we can store 2 entries in the query level cache, as can be seen in the image.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
