[
https://issues.apache.org/jira/browse/HIVE-26226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536109#comment-17536109
]
Stamatis Zampetakis commented on HIVE-26226:
--------------------------------------------
Since jdk.tools comes from a dependency with provided scope then if compilation
and tests run fine after removal I guess it is safe.
There are some caveats though cause if the existing tests do not reach the code
which needs the removed dependency then by removing a dependency we could be
breaking something without noticing. However, I doubt that jdk.tools are ever
needed at runtime so we should be good to go.
Other than that I am a bit skeptical about the upgrade-acid module and
compilation with JDK 11. The {{PreUpgradeTool}} is meant to run with Hive 2
binaries which are compiled with jdk <= 8. What will happen if we now compile
the {{PreUpgradeTool}} with JDK11? Which JDK should the end-user use to run the
{{PreUpgradeTool}}?
> Remove outdated dependency to jdk.tools:jdk.tools:jar:1.7 (upgrade-acid)
> ------------------------------------------------------------------------
>
> Key: HIVE-26226
> URL: https://issues.apache.org/jira/browse/HIVE-26226
> Project: Hive
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 3.1.3, 4.0.0-alpha-2
> Reporter: Sylwester Lachiewicz
> Priority: Minor
>
> The hive-metastore 2.3.3 used in upgrade-acid tests includes unnecessary
> dependency - that blocks the possibility to compile with newer java versions
> > 8
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
