[
https://issues.apache.org/jira/browse/HIVE-26217?focusedWorklogId=773322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773322
]
ASF GitHub Bot logged work on HIVE-26217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 07:32
Start Date: 23/May/22 07:32
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3281:
URL: https://github.com/apache/hive/pull/3281#discussion_r879110909
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7601,13 +7619,14 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
} catch (LockException ex) {
throw new SemanticException("Failed to allocate write Id", ex);
}
- if (AcidUtils.isInsertOnlyTable(tblProps, true)) {
- isMmTable = isMmCreate = true;
+ if (isMmTable) {
if (tblDesc != null) {
- tblDesc.setInitialMmWriteId(writeId);
+ tblDesc.setInitialWriteId(writeId);
} else {
viewDesc.setInitialMmWriteId(writeId);
}
+ } else if (isDirectInsert) {
+ tblDesc.setInitialWriteId(writeId);
Review Comment:
can we enter here when creating a view?
Issue Time Tracking
-------------------
Worklog Id: (was: 773322)
Time Spent: 3h (was: 2h 50m)
> Make CTAS use Direct Insert Semantics
> -------------------------------------
>
> Key: HIVE-26217
> URL: https://issues.apache.org/jira/browse/HIVE-26217
> Project: Hive
> Issue Type: Improvement
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> CTAS on transactional tables currently does a copy from staging location to
> table location. This can be avoided by using Direct Insert semantics. Added
> support for suffixed table locations as well.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
