[
https://issues.apache.org/jira/browse/HIVE-26196?focusedWorklogId=774056&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774056
]
ASF GitHub Bot logged work on HIVE-26196:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/22 14:49
Start Date: 24/May/22 14:49
Worklog Time Spent: 10m
Work Description: asolimando commented on code in PR #3254:
URL: https://github.com/apache/hive/pull/3254#discussion_r880613711
##########
Jenkinsfile:
##########
@@ -245,6 +245,21 @@ fi
buildHive("install -Dtest=noMatches")
}
checkPrHead()
+ stage('Sonar') {
Review Comment:
At the moment this is meant to run only for the master branch (i.e., only
after merging PRs), so I guess the additional time could be acceptable there,
but your proposal is superior, let me try to comply to that, so that we are
closer to have sonar analysis for dev branches too.
Issue Time Tracking
-------------------
Worklog Id: (was: 774056)
Time Spent: 40m (was: 0.5h)
> Integrate Sonar analysis for the master branch
> ----------------------------------------------
>
> Key: HIVE-26196
> URL: https://issues.apache.org/jira/browse/HIVE-26196
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The aim of the ticket is to integrate SonarCloud analysis for the master
> branch.
> The ticket does not cover:
> * test coverage
> * analysis on PRs and other branches
> Those aspects can be added in follow-up tickets, if there is enough interest.
> From preliminary tests, the analysis step requires 30 additional minutes for
> the pipeline.
> The idea for this first integration is to track code quality metrics over new
> commits in the master branch, without any quality gate rules (i.e., the
> analysis will never fail, independently of the values of the quality metrics).
> An example of analysis is available in my personal Sonar account:
> [https://sonarcloud.io/summary/new_code?id=asolimando_hive]
> ASF offers SonarCloud accounts for Apache projects, and Hive already has one
> (https://sonarcloud.io/project/configuration?id=apache_hive, created via
> INFRA-22542), for completing the present ticket, somebody having admin
> permissions in that repo should generated an authentication token, which
> should replace the _SONAR_TOKEN_ secret in Jenkins.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
