[
https://issues.apache.org/jira/browse/HIVE-24884?focusedWorklogId=774366&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774366
]
ASF GitHub Bot logged work on HIVE-24884:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/22 05:21
Start Date: 25/May/22 05:21
Worklog Time Spent: 10m
Work Description: hmangla98 commented on code in PR #3293:
URL: https://github.com/apache/hive/pull/3293#discussion_r881227102
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/DumpMetaData.java:
##########
@@ -117,6 +153,32 @@ private void readReplScope(String line) throws IOException
{
}
private void loadDumpFromFile() throws SemanticException {
+ boolean isInJSONFormat = resolveDumpFilePathAndGetIfV2();
+ if (isInJSONFormat) {
+ loadDumpFromFileV2();
+ } else {
+ loadDumpFromFileV1();
+ }
+ }
+
+ //Returns true if dumpmetaData is in V2 Format
+ private boolean resolveDumpFilePathAndGetIfV2() throws SemanticException {
+ if (isTopLevel) {
+ dumpFile = new Path(dumpRoot, DUMP_METADATA_V2);
+ if (Utils.fileExists(dumpFile, hiveConf)) {
+ return true;
+ }
+ //Backward-compatibility: fall back to old version. Dump might be
generated by old version
+ dumpFile = new Path(dumpRoot, DUMP_METADATA);
+ LOG.info("Falling back to old version of dump meta data {}", dumpFile);
+ } else {
+ // The nested level _dumpmetadata file content is still in old format:
To save JSON parsing cost.
+ dumpFile = new Path(dumpRoot, DUMP_METADATA);
+ }
+ return false;
+ }
+
+ private void loadDumpFromFileV1() throws SemanticException {
BufferedReader br = null;
try {
Review Comment:
Added one.
Issue Time Tracking
-------------------
Worklog Id: (was: 774366)
Time Spent: 1h 20m (was: 1h 10m)
> Move top level dump metadata content to be in JSON format
> ---------------------------------------------------------
>
> Key: HIVE-24884
> URL: https://issues.apache.org/jira/browse/HIVE-24884
> Project: Hive
> Issue Type: Task
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {color:#172b4d}The current content for _dumpmetadata file is TAB separated.
> This is not very flexible for extension. A more flexible format like JSON
> based content would be helpful for extending the content.{color}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
