[
https://issues.apache.org/jira/browse/HIVE-26261?focusedWorklogId=774932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774932
]
ASF GitHub Bot logged work on HIVE-26261:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/22 08:11
Start Date: 26/May/22 08:11
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on code in PR #3320:
URL: https://github.com/apache/hive/pull/3320#discussion_r882427374
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -158,6 +158,15 @@ private static boolean isDeferredAuthView(Table t){
if (TableType.MATERIALIZED_VIEW.name().equals(tableType) ||
TableType.VIRTUAL_VIEW.name().equals(tableType)) {
isView = true;
}
+ if (isView) {
+ Map<String, String> params = t.getParameters();
+ if (params != null && params.containsKey(authorizedKeyword)) {
Review Comment:
nice; so HIVE-25695 effectively mangled the [original condition to be spark
dependent](https://github.com/apache/hive/commit/e61460b36178de3d8f2ddb28ad3f03902a34c3a8#diff-b1bce663288d98098d8aaa474ad0694d43484b0cd1977a788dc9f6c6f7fae4d0R163)...
Issue Time Tracking
-------------------
Worklog Id: (was: 774932)
Time Spent: 0.5h (was: 20m)
> Fix some issues with Spark engine removal
> -----------------------------------------
>
> Key: HIVE-26261
> URL: https://issues.apache.org/jira/browse/HIVE-26261
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I have made some mistakes when removed the Spark code:
> * CommandAuthorizerV2.java - should check the properties. At that stage the
> authorizer was referring tables created by Spark as a HMS client, and not as
> an engine
> * There is one unused method left in MapJoinTableContainerSerDe.java
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
