[
https://issues.apache.org/jira/browse/HIVE-24484?focusedWorklogId=776123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776123
]
ASF GitHub Bot logged work on HIVE-24484:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/22 08:19
Start Date: 31/May/22 08:19
Worklog Time Spent: 10m
Work Description: abstractdog commented on code in PR #3279:
URL: https://github.com/apache/hive/pull/3279#discussion_r885341338
##########
ql/src/java/org/apache/hadoop/hive/ql/io/RecordReaderWrapper.java:
##########
@@ -69,7 +70,14 @@ static RecordReader create(InputFormat inputFormat,
HiveInputFormat.HiveInputSpl
JobConf jobConf, Reporter reporter) throws IOException {
int headerCount = Utilities.getHeaderCount(tableDesc);
int footerCount = Utilities.getFooterCount(tableDesc, jobConf);
- RecordReader innerReader =
inputFormat.getRecordReader(split.getInputSplit(), jobConf, reporter);
+
+ RecordReader innerReader = null;
+ try {
+ innerReader = inputFormat.getRecordReader(split.getInputSplit(), jobConf,
reporter);
+ } catch (InterruptedIOException iioe) {
+ // If reading from the underlying record reader is interrupted, return a
no-op record reader
Review Comment:
the explanation on the other PR makes sense to me...considering that we only
catch InterruptedIOException here, I'm fine with ZeroRowsInputFormat, but for
future code readers, this is confusing, let's do the following:
1. put a log line here marking this branch
2. make a comment: in which scenarios does this happen?, who's typically
interrupting this codepath?
Issue Time Tracking
-------------------
Worklog Id: (was: 776123)
Time Spent: 10h 53m (was: 10h 43m)
> Upgrade Hadoop to 3.3.1
> -----------------------
>
> Key: HIVE-24484
> URL: https://issues.apache.org/jira/browse/HIVE-24484
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 53m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
