[
https://issues.apache.org/jira/browse/HIVE-26196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Solimando updated HIVE-26196:
----------------------------------------
Description:
The aim of the ticket is to integrate SonarCloud analysis for the master branch
and PRs.
The ticket does not cover test coverage at the moment (it can be added in
follow-up tickets, if there is enough interest).
>From preliminary tests, the analysis step requires 30 additional minutes for
>the pipeline, but this step is run in parallel with the test run, so the total
>end-to-end run-time is not affected.
The idea for this first integration is to track code quality metrics over new
commits in the master branch and for PRs, without any quality gate rules (i.e.,
the analysis will never fail, independently of the values of the quality
metrics).
An example of analysis is available in the ASF Sonar account for Hive: [PR
analysis|https://sonarcloud.io/summary/new_code?id=apache_hive&pullRequest=3254]
After integrating the changes, PRs will also be decorated with a link to the
analysis to be able to better evaluate any pain points of the contribution at
an earlier stage, making the life of the reviewers a bit easier.
was:
The aim of the ticket is to integrate SonarCloud analysis for the master branch.
The ticket does not cover:
* test coverage
* analysis on PRs and other branches
Those aspects can be added in follow-up tickets, if there is enough interest.
>From preliminary tests, the analysis step requires 30 additional minutes for
>the pipeline.
The idea for this first integration is to track code quality metrics over new
commits in the master branch, without any quality gate rules (i.e., the
analysis will never fail, independently of the values of the quality metrics).
An example of analysis is available in my personal Sonar account:
[https://sonarcloud.io/summary/new_code?id=asolimando_hive]
ASF offers SonarCloud accounts for Apache projects, and Hive already has one
(https://sonarcloud.io/project/configuration?id=apache_hive, created via
INFRA-22542), for completing the present ticket, somebody having admin
permissions in that repo should generated an authentication token, which should
replace the _SONAR_TOKEN_ secret in Jenkins.
> Integrate Sonar analysis for the master branch and PRs
> ------------------------------------------------------
>
> Key: HIVE-26196
> URL: https://issues.apache.org/jira/browse/HIVE-26196
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The aim of the ticket is to integrate SonarCloud analysis for the master
> branch and PRs.
> The ticket does not cover test coverage at the moment (it can be added in
> follow-up tickets, if there is enough interest).
> From preliminary tests, the analysis step requires 30 additional minutes for
> the pipeline, but this step is run in parallel with the test run, so the
> total end-to-end run-time is not affected.
> The idea for this first integration is to track code quality metrics over new
> commits in the master branch and for PRs, without any quality gate rules
> (i.e., the analysis will never fail, independently of the values of the
> quality metrics).
> An example of analysis is available in the ASF Sonar account for Hive: [PR
> analysis|https://sonarcloud.io/summary/new_code?id=apache_hive&pullRequest=3254]
> After integrating the changes, PRs will also be decorated with a link to the
> analysis to be able to better evaluate any pain points of the contribution at
> an earlier stage, making the life of the reviewers a bit easier.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
