[
https://issues.apache.org/jira/browse/HIVE-26196?focusedWorklogId=777009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777009
]
ASF GitHub Bot logged work on HIVE-26196:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/22 16:49
Start Date: 01/Jun/22 16:49
Worklog Time Spent: 10m
Work Description: asolimando commented on PR #3254:
URL: https://github.com/apache/hive/pull/3254#issuecomment-1143867392
@kgyrtkirk can you have another look? At the moment we are analyzing PRs and
the master branch, I don't think we need to support labels or anything, because
whatever change we want to make has to pass through a PR, we will spot eventual
issues before merging, so I think we can stick with just analyzing the master
branch. WDYT?
PS: I have updated the title of the Jira ticket, the message of the first
commit is outdated, I am not amending it because otherwise it will trigger CI
again for nothing.
Issue Time Tracking
-------------------
Worklog Id: (was: 777009)
Time Spent: 1h 10m (was: 1h)
> Integrate Sonar analysis for the master branch and PRs
> ------------------------------------------------------
>
> Key: HIVE-26196
> URL: https://issues.apache.org/jira/browse/HIVE-26196
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The aim of the ticket is to integrate SonarCloud analysis for the master
> branch and PRs.
> The ticket does not cover test coverage at the moment (it can be added in
> follow-up tickets, if there is enough interest).
> From preliminary tests, the analysis step requires 30 additional minutes for
> the pipeline, but this step is run in parallel with the test run, so the
> total end-to-end run-time is not affected.
> The idea for this first integration is to track code quality metrics over new
> commits in the master branch and for PRs, without any quality gate rules
> (i.e., the analysis will never fail, independently of the values of the
> quality metrics).
> An example of analysis is available in the ASF Sonar account for Hive: [PR
> analysis|https://sonarcloud.io/summary/new_code?id=apache_hive&pullRequest=3254]
> After integrating the changes, PRs will also be decorated with a link to the
> analysis to be able to better evaluate any pain points of the contribution at
> an earlier stage, making the life of the reviewers a bit easier.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
