[ 
https://issues.apache.org/jira/browse/HIVE-26228?focusedWorklogId=777493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777493
 ]

ASF GitHub Bot logged work on HIVE-26228:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/22 12:58
            Start Date: 02/Jun/22 12:58
    Worklog Time Spent: 10m 
      Work Description: lcspinter commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r887922632


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/AbstractBaseAlterTableAnalyzer.java:
##########
@@ -161,7 +161,8 @@ protected void validateAlterTableType(Table table, 
AlterTableType op, boolean ex
     }
     if (table.isNonNative() && table.getStorageHandler() != null) {
       if (!table.getStorageHandler().isAllowedAlterOperation(op) ||

Review Comment:
   Yes, you are right, all this can be combined into isAllowedAlterOperation()





Issue Time Tracking
-------------------

    Worklog Id:     (was: 777493)
    Time Spent: 4h 40m  (was: 4.5h)

> Implement Iceberg table rollback feature
> ----------------------------------------
>
>                 Key: HIVE-26228
>                 URL: https://issues.apache.org/jira/browse/HIVE-26228
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> We should allow rolling back iceberg table's data to the state at an older 
> table snapshot. 
> Rollback to the last snapshot before a specific timestamp
> {code:java}
> ALTER TABLE ice_t EXECUTE ROLLBACK('2022-05-12 00:00:00')
> {code}
> Rollback to a specific snapshot ID
> {code:java}
>  ALTER TABLE ice_t EXECUTE ROLLBACK(1111); 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to