[
https://issues.apache.org/jira/browse/HIVE-26144?focusedWorklogId=778919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778919
]
ASF GitHub Bot logged work on HIVE-26144:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/22 08:06
Start Date: 07/Jun/22 08:06
Worklog Time Spent: 10m
Work Description: kovjanos commented on code in PR #3214:
URL: https://github.com/apache/hive/pull/3214#discussion_r890895066
##########
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0-alpha-2.derby.sql:
##########
@@ -570,7 +571,8 @@ CREATE TABLE COMPLETED_TXN_COMPONENTS (
CTC_PARTITION varchar(767),
CTC_TIMESTAMP timestamp DEFAULT CURRENT_TIMESTAMP NOT NULL,
CTC_WRITEID bigint,
- CTC_UPDATE_DELETE char(1) NOT NULL
+ CTC_UPDATE_DELETE char(1) NOT NULL,
+ CTC_ID bigint PRIMARY KEY GENERATED BY DEFAULT AS IDENTITY
Review Comment:
Thanks for the review @deniskuzZ! Based on the above tests, that's only a
problem for Oracle as others - Derby, PgSQL, MySQL, MSSQL - all generate uniq
value for the multi-line inserts. As soon as out from other ticket I'll test
the Oracle case if the cleaner queries do better plans or not with the identity
to see if a sequence based column would be needed or just an identity column to
keep schema consistent across all engines.
Issue Time Tracking
-------------------
Worklog Id: (was: 778919)
Time Spent: 1h 10m (was: 1h)
> Add keys/indexes to support highly concurrent workload
> ------------------------------------------------------
>
> Key: HIVE-26144
> URL: https://issues.apache.org/jira/browse/HIVE-26144
> Project: Hive
> Issue Type: Sub-task
> Components: Database/Schema
> Reporter: Janos Kovacs
> Assignee: Janos Kovacs
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The following indexes are added to avoid full table-scan in backend rdbms:
> - primary key for COMPLETED_TXN_COMPONENTS
> - primary key for TXN_COMPONENTS
> - index for TXN_WRITE_NOTIFICATION_LOG
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
