[
https://issues.apache.org/jira/browse/HIVE-26285?focusedWorklogId=779564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779564
]
ASF GitHub Bot logged work on HIVE-26285:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/22 16:17
Start Date: 08/Jun/22 16:17
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3346:
URL: https://github.com/apache/hive/pull/3346#discussion_r892586679
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java:
##########
@@ -739,6 +741,23 @@ private int executeIncrementalLoad(long loadStartTime)
throws Exception {
LOG.info("Dropping table {} for optimised bootstarap",
work.dbNameToLoadIn + "." + table);
db.dropTable(work.dbNameToLoadIn + "." + table, true);
}
+ Database sourceDb = getSourceDbMetadata(); //This sourceDb was the
actual target prior to failover.
+ Map<String, String> sourceDbProps = sourceDb.getParameters();
+ List<String> replicationProps = MetaStoreUtils.getReplicationDbProps();
//Replication Props will be handled separately as part of preAckTask.
+ for (Map.Entry<String, String> currProp :
targetDb.getParameters().entrySet()) {
Review Comment:
should we do a pre-filter to avoid the lookups?
````
Map<String, String> props = targetDb.getParameters();
for (String key : replicationProps) {
props.remove(key);
}
````
Issue Time Tracking
-------------------
Worklog Id: (was: 779564)
Time Spent: 1h 10m (was: 1h)
> Overwrite database metadata on original source in optimised failover.
> ---------------------------------------------------------------------
>
> Key: HIVE-26285
> URL: https://issues.apache.org/jira/browse/HIVE-26285
> Project: Hive
> Issue Type: Sub-task
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
