[
https://issues.apache.org/jira/browse/HIVE-26299?focusedWorklogId=779579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779579
]
ASF GitHub Bot logged work on HIVE-26299:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/22 16:45
Start Date: 08/Jun/22 16:45
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3350:
URL: https://github.com/apache/hive/pull/3350#discussion_r892614139
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -2041,16 +2041,16 @@ public void drop_dataconnector(final String dcName,
boolean ifNotExists, boolean
Exception ex = null;
RawStore ms = getMS();
try {
- ms.openTransaction();
connector = getMS().getDataConnector(dcName);
-
- if (connector == null) {
- if (!ifNotExists) {
- throw new NoSuchObjectException("DataConnector " + dcName + "
doesn't exist");
- } else {
- return;
- }
+ } catch (NoSuchObjectException e) {
Review Comment:
With this change we don't require
[TestFilterHooks.java](https://github.com/apache/hive/pull/3304/files#diff-568151a80b62a98c19409989a18c38d8f90f71fddbf06286641821228f75dd9d)
L228 and L231 anymore right?
Issue Time Tracking
-------------------
Worklog Id: (was: 779579)
Time Spent: 20m (was: 10m)
> Drop data connector with argument ifNotExists(true) should not throw
> NoSuchObjectException
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-26299
> URL: https://issues.apache.org/jira/browse/HIVE-26299
> Project: Hive
> Issue Type: Bug
> Affects Versions: 4.0.0-alpha-2
> Reporter: zhangbutao
> Assignee: zhangbutao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
