[
https://issues.apache.org/jira/browse/HIVE-26301?focusedWorklogId=779866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779866
]
ASF GitHub Bot logged work on HIVE-26301:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/22 10:33
Start Date: 09/Jun/22 10:33
Worklog Time Spent: 10m
Work Description: hmangla98 commented on code in PR #3352:
URL: https://github.com/apache/hive/pull/3352#discussion_r893342479
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1089,9 +1089,8 @@ private boolean
needBootstrapAcidTablesDuringIncrementalDump() {
// of the ACID tables might be included for bootstrap during incremental
dump. For old policy, its because the table
// may not satisfying the old policy but satisfying the new policy. For
filter, it may happen that the table
// is renamed and started satisfying the policy.
- return ((!work.replScope.includeAllTables())
- || (previousReplScopeModified())
- || conf.getBoolVar(HiveConf.ConfVars.REPL_BOOTSTRAP_ACID_TABLES));
+ return !work.replScope.includeAllTables() || previousReplScopeModified()
|| !tablesForBootstrap.isEmpty()
Review Comment:
Actually, function name "needBootstrapAcidTablesDuringIncrementalDump" is
itself intuitive enough to signify that if tablesForBootstrap is non-empty, we
need to bootstrap them.
Issue Time Tracking
-------------------
Worklog Id: (was: 779866)
Time Spent: 40m (was: 0.5h)
> Fix ACID tables bootstrap during reverse replication in unplanned failover.
> ---------------------------------------------------------------------------
>
> Key: HIVE-26301
> URL: https://issues.apache.org/jira/browse/HIVE-26301
> Project: Hive
> Issue Type: Sub-task
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
