[
https://issues.apache.org/jira/browse/HIVE-25879?focusedWorklogId=780869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780869
]
ASF GitHub Bot logged work on HIVE-25879:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/22 15:30
Start Date: 13/Jun/22 15:30
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on code in PR #3348:
URL: https://github.com/apache/hive/pull/3348#discussion_r895859650
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java:
##########
@@ -316,17 +316,20 @@ private boolean ensureDbInit() {
}
private boolean runTestQuery() {
+ boolean doTrace = LOG.isDebugEnabled();
Transaction tx = pm.currentTransaction();
boolean doCommit = false;
if (!tx.isActive()) {
tx.begin();
doCommit = true;
}
// Run a self-test query. If it doesn't work, we will self-disable. What a
PITA...
- String selfTestQuery = "select \"DB_ID\" from " + DBS + "";
+ String selfTestQuery = "select \"DB_ID\" from " + DBS + " WHERE
\"DB_ID\"=1";
Review Comment:
`where 1=0` sounds good to me...or `DB_ID=-1`; but this will be ok as well
Issue Time Tracking
-------------------
Worklog Id: (was: 780869)
Time Spent: 1.5h (was: 1h 20m)
> MetaStoreDirectSql test query should not query the whole DBS table
> ------------------------------------------------------------------
>
> Key: HIVE-25879
> URL: https://issues.apache.org/jira/browse/HIVE-25879
> Project: Hive
> Issue Type: Bug
> Reporter: Miklos Szurap
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The runTestQuery() in the
> org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java is using a test query
> {code:java}
> select "DB_ID" from "DBS"{code}
> to determine whether the direct SQL can be used.
> With larger deployments with many (10k+) Hive databases it would be more
> efficienct to query a small table instead, for example the "VERSION" table
> should always have a single row only.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
