[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=781102&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781102
]
ASF GitHub Bot logged work on HIVE-26244:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/22 11:24
Start Date: 14/Jun/22 11:24
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r896696959
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5297,6 +5303,28 @@ is performed on that db (e.g. show tables, created
table, etc).
return response;
}
}
+
+ if (checkForConcurrentCtas && isValidTxn(txnId)) {
Review Comment:
embed this check with above zeroWaitReadEnabled
````
if ((zeroWaitReadEnabled || isExclusiveCTAS) && isValidTxn(txnId)) {
....
if (lockType == LockType.SHARED_READ || isExclusiveCTAS) {
....
````
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5297,6 +5303,28 @@ is performed on that db (e.g. show tables, created
table, etc).
return response;
}
}
+
+ if (checkForConcurrentCtas && isValidTxn(txnId)) {
Review Comment:
embed this check with the above zeroWaitReadEnabled
````
if ((zeroWaitReadEnabled || isExclusiveCTAS) && isValidTxn(txnId)) {
....
if (lockType == LockType.SHARED_READ || isExclusiveCTAS) {
....
````
Issue Time Tracking
-------------------
Worklog Id: (was: 781102)
Time Spent: 6h 10m (was: 6h)
> Implementing locking for concurrent ctas
> ----------------------------------------
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri G
> Assignee: Simhadri G
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
