[
https://issues.apache.org/jira/browse/HIVE-26319?focusedWorklogId=781982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781982
]
ASF GitHub Bot logged work on HIVE-26319:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jun/22 09:31
Start Date: 16/Jun/22 09:31
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3362:
URL: https://github.com/apache/hive/pull/3362#discussion_r898890734
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -858,19 +862,24 @@ private static boolean
hasParquetListColumnSupport(Properties tableProps, Schema
* @param overwrite If we have to overwrite the existing table or just add
the new data
* @return The generated JobContext
*/
- private Optional<JobContext> generateJobContext(Configuration configuration,
String tableName, boolean overwrite) {
+ private Optional<List<JobContext>> generateJobContext(
Review Comment:
nit: In Iceberg code we usually break lines like this:
```
private Optional<List<JobContext>> generateJobContext(Configuration
configuration, String tableName,
boolean overwrite) {
```
Issue Time Tracking
-------------------
Worklog Id: (was: 781982)
Time Spent: 1h (was: 50m)
> Iceberg integration: Perform update split early
> -----------------------------------------------
>
> Key: HIVE-26319
> URL: https://issues.apache.org/jira/browse/HIVE-26319
> Project: Hive
> Issue Type: Improvement
> Components: File Formats
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Extend update split early to iceberg tables like in HIVE-21160 for native
> acid tables
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
