[
https://issues.apache.org/jira/browse/HIVE-26314?focusedWorklogId=782091&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782091
]
ASF GitHub Bot logged work on HIVE-26314:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jun/22 15:52
Start Date: 16/Jun/22 15:52
Worklog Time Spent: 10m
Work Description: wecharyu commented on code in PR #3360:
URL: https://github.com/apache/hive/pull/3360#discussion_r899246871
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/function/create/CreateFunctionOperation.java:
##########
@@ -116,11 +119,27 @@ private int createPermanentFunction() throws
HiveException, IOException {
return 1;
}
- boolean addToMetastoreSuccess = addToMetastore(dbName, functionName,
registeredName);
- if (!addToMetastoreSuccess) {
+ // TODO: should this use getUserFromAuthenticator instead of
SessionState.get().getUserName()?
+ Function function = new Function(functionName, dbName,
desc.getClassName(), SessionState.get().getUserName(),
Review Comment:
Can we add `OWNER_PRIV` for altering function? Then only the owner of this
function can do alter operation.
Issue Time Tracking
-------------------
Worklog Id: (was: 782091)
Time Spent: 1h 20m (was: 1h 10m)
> Support alter function in Hive DDL
> ----------------------------------
>
> Key: HIVE-26314
> URL: https://issues.apache.org/jira/browse/HIVE-26314
> Project: Hive
> Issue Type: Task
> Components: Hive
> Affects Versions: 4.0.0-alpha-1
> Reporter: Wechar
> Assignee: Wechar
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-2
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Hive SQL does not support {{*ALTER FUNCTION*}} yet, we can refer to the
> {{*CREATE [OR REPLACE] FUNCTION*}} of
> [Spark|https://spark.apache.org/docs/3.1.2/sql-ref-syntax-ddl-create-function.html]
> to implement the alter function .
> {code:sql}
> CREATE [ TEMPORARY ] FUNCTION [ OR REPLACE ] [IF NOT EXISTS ]
> [db_name.]function_name AS class_name
> [USING JAR|FILE|ARCHIVE 'file_uri' [, JAR|FILE|ARCHIVE 'file_uri'] ];
> {code}
> * *OR REPLACE*
> If specified, the resources for the function are reloaded. This is mainly
> useful to pick up any changes made to the implementation of the function.
> This parameter is mutually exclusive to {{*IF NOT EXISTS*}} and can not be
> specified together.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
