[
https://issues.apache.org/jira/browse/HIVE-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975621#comment-14975621
]
Xuefu Zhang commented on HIVE-11120:
------------------------------------
I briefly looked over the patch. On a high level, it looks good to me. However,
I'm a little concerned about the synchronization which seemingly exists in the
code but is not introduced by the patch here. Specifically, I'm not sure how
thread safety is ensured in the following method:
HiveFileFormatUtils.checkInputFormat().
> Generic interface for file format validation
> --------------------------------------------
>
> Key: HIVE-11120
> URL: https://issues.apache.org/jira/browse/HIVE-11120
> Project: Hive
> Issue Type: Bug
> Affects Versions: 1.3.0, 2.0.0
> Reporter: Prasanth Jayachandran
> Assignee: Prasanth Jayachandran
> Attachments: HIVE-11120.patch
>
>
> https://issues.apache.org/jira/browse/HIVE-11118?focusedCommentId=14602302&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14602302
> We need generic interfaces for verify if a specified file is of valid format
> so that load data statement can make some sanity check before copying the
> file to destination.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
