[
https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=783540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783540
]
ASF GitHub Bot logged work on HIVE-21456:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/22 19:24
Start Date: 21/Jun/22 19:24
Worklog Time Spent: 10m
Work Description: sourabh912 commented on code in PR #3381:
URL: https://github.com/apache/hive/pull/3381#discussion_r902988116
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -461,6 +459,14 @@ public Thread newThread(@NotNull Runnable r) {
// TODO: AcceptQueueSize needs to be higher for HMS
connector.setAcceptQueueSize(maxWorkerThreads);
// TODO: Connection keepalive configuration?
+ connector.addBean(new HttpChannel.Listener() {
+ @Override
+ public void onComplete(Request request) {
+ LOG.debug("Request " + request + " is completed. HttpChannel was: " +
request.getHttpChannel()
+ + ", HttpTransport: " +
request.getHttpChannel().getHttpTransport());
+ HMSHandler.cleanupHandlerContext();
Review Comment:
`testJDOPersistanceManagerCleanup` in TestHiveMetaStore is testing that. The
failure in that test led to the fixes proposed in this patch. Without this
patch, testJDOPersistanceManagerCleanup() fails in Thrift over HTTP mode.
Issue Time Tracking
-------------------
Worklog Id: (was: 783540)
Time Spent: 8h (was: 7h 50m)
> Hive Metastore Thrift over HTTP
> -------------------------------
>
> Key: HIVE-21456
> URL: https://issues.apache.org/jira/browse/HIVE-21456
> Project: Hive
> Issue Type: New Feature
> Components: Metastore, Standalone Metastore
> Reporter: Amit Khanna
> Assignee: Sourabh Goyal
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch,
> HIVE-21456.4.patch, HIVE-21456.patch
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> Hive Metastore currently doesn't have support for HTTP transport because of
> which it is not possible to access it via Knox. Adding support for Thrift
> over HTTP transport will allow the clients to access via Knox
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
