[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=783767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783767
]
ASF GitHub Bot logged work on HIVE-26244:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/22 08:35
Start Date: 22/Jun/22 08:35
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r903452007
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -3225,6 +3237,14 @@ public static String getPathSuffix(long txnId) {
return (SOFT_DELETE_PATH_SUFFIX + String.format(DELTA_DIGITS, txnId));
}
+ public static boolean isExclusiveCTASEnabled(Configuration conf) {
+ return HiveConf.getBoolVar(conf, ConfVars.TXN_CTAS_X_LOCK);
+ }
+
+ public static boolean isExclusiveCTASEnabled(Table t, Configuration conf) {
+ return HiveConf.getBoolVar(conf, ConfVars.TXN_CTAS_X_LOCK) &&
isTransactionalTable(t);
Review Comment:
if you'll be submitting new fixes, could we please rename just this method
to `isTableExclusiveCTASEnabled` to avoid confusion with
`isExclusiveCTASEnabled` or just remove isExclusiveCTASEnabled - it's using in
1 place so you could just directly access conf there.
Issue Time Tracking
-------------------
Worklog Id: (was: 783767)
Time Spent: 10h 20m (was: 10h 10m)
> Implementing locking for concurrent ctas
> ----------------------------------------
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri G
> Assignee: Simhadri G
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
