[
https://issues.apache.org/jira/browse/HIVE-26055?focusedWorklogId=784352&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784352
]
ASF GitHub Bot logged work on HIVE-26055:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/22 21:04
Start Date: 23/Jun/22 21:04
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3247:
URL: https://github.com/apache/hive/pull/3247#discussion_r905448252
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/misc/rename/AbstractAlterTableRenameAnalyzer.java:
##########
@@ -49,6 +55,11 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
setAcidDdlDesc(desc);
}
addInputsOutputsAlterTable(tableName, null, desc, desc.getType(), false);
+ String newDatabaseName = target.getDb() != null ? target.getDb() :
table.getDbName(); // extract new database name from new table name, if not
specified, then src dbname is used
+ Database newDatabase = getDatabase(newDatabaseName);
+ outputs.add(new WriteEntity(newDatabase,
WriteEntity.WriteType.DDL_NO_LOCK));
+ Table newTable = new Table(target.getDb(), target.getTable());
+ outputs.add(new WriteEntity(newTable,
WriteEntity.WriteType.DDL_EXCLUSIVE));
Review Comment:
Why the change in locking? Why do we need an `EXCLUSIVE` lock on not yet
existing table + `NO_LOCK` on the DB level?
Note that `addInputsOutputsAlterTable(...)` already adds an `EXCLUSIVE` or
`EXCL_WRITE`, depending on a config, to the original table.
Issue Time Tracking
-------------------
Worklog Id: (was: 784352)
Time Spent: 1h 40m (was: 1.5h)
> Fix the HivePrivilegesObjects for Alter table rename command
> ------------------------------------------------------------
>
> Key: HIVE-26055
> URL: https://issues.apache.org/jira/browse/HIVE-26055
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Security
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Fix the HivePrivilegeObjects for Alter table rename query in a way that it
> includes source table information in the output objects and destination table
> information in the input objects.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
