[
https://issues.apache.org/jira/browse/HIVE-26265?focusedWorklogId=784988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784988
]
ASF GitHub Bot logged work on HIVE-26265:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 08:38
Start Date: 27/Jun/22 08:38
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3365:
URL: https://github.com/apache/hive/pull/3365#discussion_r907124765
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -5615,7 +5615,12 @@ public static enum ConfVars {
HIVE_ADDITIONAL_CONFIG_FILES("hive.additional.config.files", "",
"The names of additional config files, such as ldap-site.xml," +
- "tez-site.xml, etc in comma separated list.");
+ "tez-site.xml, etc in comma separated list."),
+
+ REPL_FILTER_TRANSACTIONS("hive.repl.filter.transactions", false,
+ "Enable transaction event filtering to save dump space.\n" +
+ "When true, transactions are implicitly opened during REPL
DUMP.\n" +
Review Comment:
Not sure about the `RESTORE` - we need to use the same names as we use other
filters.
```
"Enable transaction event filtering to save dump space.\n" +
"When true, opening transactions do not generate events, and
transactions on the target " +
"server are implicitly opened during REPL RESTORE.\n" +
"The default setting is false");
```
We want this config to be around the other `REPL` related configs, not at
the end of the list.
Issue Time Tracking
-------------------
Worklog Id: (was: 784988)
Time Spent: 3h 20m (was: 3h 10m)
> REPL DUMP should filter out OpenXacts and unneeded CommitXact/Abort.
> --------------------------------------------------------------------
>
> Key: HIVE-26265
> URL: https://issues.apache.org/jira/browse/HIVE-26265
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: francis pang
> Assignee: francis pang
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> REPL DUMP is replication all OpenXacts, even when they are from other non
> replicated databases. This wastes space in the dump, and ends up opening
> unneeded transactions during REPL LOAD.
>
> Add a config property for replication that filters out OpenXact events during
> REPL DUMP. During REPL LOAD, the txns can be implicitly opened when the
> ALLOC_WRITE_ID is processed. For CommitTxn and AbortTxn, dump only if WRITE
> ID was allocated.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
