[
https://issues.apache.org/jira/browse/HIVE-26242?focusedWorklogId=785085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785085
]
ASF GitHub Bot logged work on HIVE-26242:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 13:15
Start Date: 27/Jun/22 13:15
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3303:
URL: https://github.com/apache/hive/pull/3303#discussion_r907376912
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/IMetaStoreClientFactory.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.txn.compactor;
+
+import org.apache.commons.pool2.BasePooledObjectFactory;
+import org.apache.commons.pool2.PooledObject;
+import org.apache.commons.pool2.impl.DefaultPooledObject;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.HiveMetaStoreUtils;
+import org.apache.hadoop.hive.metastore.IMetaStoreClient;
+
+import java.util.Objects;
+
+final class IMetaStoreClientFactory extends
BasePooledObjectFactory<IMetaStoreClient> {
+
+ private final HiveConf conf;
+
+ @Override
+ public IMetaStoreClient create() throws Exception {
+ return HiveMetaStoreUtils.getHiveMetastoreClient(conf);
+ }
+
+ @Override
+ public PooledObject<IMetaStoreClient> wrap(IMetaStoreClient
iMetaStoreClient) {
+ return new DefaultPooledObject<>(iMetaStoreClient);
+ }
+
+ @Override
+ public void destroyObject(PooledObject<IMetaStoreClient> p) {
+ p.getObject().close();
+ }
+
+ @Override
+ public boolean validateObject(PooledObject<IMetaStoreClient> p) {
Review Comment:
p -> msc
Issue Time Tracking
-------------------
Worklog Id: (was: 785085)
Time Spent: 5.5h (was: 5h 20m)
> Compaction heartbeater improvements
> -----------------------------------
>
> Key: HIVE-26242
> URL: https://issues.apache.org/jira/browse/HIVE-26242
> Project: Hive
> Issue Type: Improvement
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> The Compaction heartbeater should be improved the following ways:
> * The metastore clients should be reused between heartbeats and closed only
> at the end, when the transaction ends
> * Instead of having a dedicated heartbeater thread for each Compaction
> transaction, there should be shared a heartbeater executor where the
> heartbeat tasks can be scheduled/submitted.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
