[
https://issues.apache.org/jira/browse/HIVE-26354?focusedWorklogId=785114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785114
]
ASF GitHub Bot logged work on HIVE-26354:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 14:09
Start Date: 27/Jun/22 14:09
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3401:
URL: https://github.com/apache/hive/pull/3401#discussion_r907433464
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/execute/AlterTableExecuteAnalyzer.java:
##########
@@ -72,14 +75,26 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
ZoneId timeZone = SessionState.get() == null ? new
HiveConf().getLocalTimeZone() : SessionState.get().getConf()
.getLocalTimeZone();
TimestampTZ time =
TimestampTZUtil.parse(PlanUtils.stripQuotes(child.getText()), timeZone);
- spec = new AlterTableExecuteSpec(ROLLBACK, new
AlterTableExecuteSpec.RollbackSpec(TIME, time.toEpochMilli()));
+ spec = new AlterTableExecuteSpec(ROLLBACK, new RollbackSpec(TIME,
time.toEpochMilli()));
} else {
- spec = new AlterTableExecuteSpec(ROLLBACK, new
AlterTableExecuteSpec.RollbackSpec(VERSION,
+ spec = new AlterTableExecuteSpec(ROLLBACK, new RollbackSpec(VERSION,
Long.valueOf(child.getText())));
}
desc = new AlterTableExecuteDesc(tableName, partitionSpec, spec);
}
+ if (HiveParser.KW_EXPIRE_SNAPSHOTS == executeCommandType.getType()) {
Review Comment:
done
Issue Time Tracking
-------------------
Worklog Id: (was: 785114)
Time Spent: 40m (was: 0.5h)
> Support expiring snapshots on iceberg table
> -------------------------------------------
>
> Key: HIVE-26354
> URL: https://issues.apache.org/jira/browse/HIVE-26354
> Project: Hive
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> It would be good to support expire snapshots for Iceberg tables.
> The syntax could be something like below:
> {code}
> ALTER TABLE test_table EXECUTE expire_snapshots('timestamp');
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
