[
https://issues.apache.org/jira/browse/HIVE-26242?focusedWorklogId=785205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785205
]
ASF GitHub Bot logged work on HIVE-26242:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/22 18:33
Start Date: 27/Jun/22 18:33
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on PR #3303:
URL: https://github.com/apache/hive/pull/3303#issuecomment-1167729672
> I think we should do something like this:
>
> ```
> ExecutorService executorService =
CompactorUtil.createExecutorWithThreadFactory(numberOfWorkers,
"CompactionHeartbeat-executor-thread-%d");
>
> Future<?> submittedTask = heartbeatExecutor.scheduleAtFixedRate(() ->
executorService.execute(heartbeater));
> tasks.put(txnId, new TaskWrapper(heartbeater, submittedTask));
> ```
What is the benefit of this construct?
Issue Time Tracking
-------------------
Worklog Id: (was: 785205)
Time Spent: 8h 20m (was: 8h 10m)
> Compaction heartbeater improvements
> -----------------------------------
>
> Key: HIVE-26242
> URL: https://issues.apache.org/jira/browse/HIVE-26242
> Project: Hive
> Issue Type: Improvement
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> The Compaction heartbeater should be improved the following ways:
> * The metastore clients should be reused between heartbeats and closed only
> at the end, when the transaction ends
> * Instead of having a dedicated heartbeater thread for each Compaction
> transaction, there should be shared a heartbeater executor where the
> heartbeat tasks can be scheduled/submitted.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
