[ 
https://issues.apache.org/jira/browse/HIVE-26057?focusedWorklogId=786452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786452
 ]

ASF GitHub Bot logged work on HIVE-26057:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jun/22 08:05
            Start Date: 30/Jun/22 08:05
    Worklog Time Spent: 10m 
      Work Description: dengzhhu653 commented on PR #3124:
URL: https://github.com/apache/hive/pull/3124#issuecomment-1170901042

   > > sorry for the poor changes that I made
   > 
   > @dengzhhu653: 
[HIVE-23633](https://issues.apache.org/jira/browse/HIVE-23633) solved a serious 
issue. That was important to get in. Any specific reason you think this is 
solution is much better?
   
   Before this, There are 76 overriden methods in QueryWrapper, most of which 
take no effect, so after cleaned, there are about 18 methods in QueryWrapper, 
it can reduce further maintaince of this proxy class.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 786452)
    Time Spent: 1h  (was: 50m)

> Clean useless methods in QueryWrapper
> -------------------------------------
>
>                 Key: HIVE-26057
>                 URL: https://issues.apache.org/jira/browse/HIVE-26057
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zhihua Deng
>            Assignee: Zhihua Deng
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Now the QueryWrapper implements Query which has dozens of overridden methods 
> with no use in codebase, these methods can be cleaned to keep it simple for 
> maintaining.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to