[ 
https://issues.apache.org/jira/browse/HIVE-26395?focusedWorklogId=791112&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-791112
 ]

ASF GitHub Bot logged work on HIVE-26395:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jul/22 19:42
            Start Date: 14/Jul/22 19:42
    Worklog Time Spent: 10m 
      Work Description: jfsii commented on code in PR #3443:
URL: https://github.com/apache/hive/pull/3443#discussion_r921511436


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -13477,6 +13480,23 @@ private boolean hasConstraints(final List<FieldSchema> 
partCols, final List<SQLD
     }
     return false;
   }
+
+  boolean doesSupportSchemaInference(String fileFormat) throws 
SemanticException {
+    StorageFormatFactory storageFormatFactory = new StorageFormatFactory();
+    StorageFormatDescriptor descriptor = storageFormatFactory.get(fileFormat);
+    if (descriptor == null) {
+      throw new SemanticException("CREATE TABLE LIKE FILE is not supported by 
the '" + likeFileFormat + "' file format");

Review Comment:
   I've added them for the changes in SemanticAnalyzer and CreateTableOperation.
   Should I do the same for the Serde error messages too?
   (I also fixed the compilation error here, I guess that is what I get for a 
last minute change)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 791112)
    Time Spent: 50m  (was: 40m)

> Support CREATE TABLE LIKE FILE for PARQUET
> ------------------------------------------
>
>                 Key: HIVE-26395
>                 URL: https://issues.apache.org/jira/browse/HIVE-26395
>             Project: Hive
>          Issue Type: New Feature
>          Components: HiveServer2
>            Reporter: John Sherman
>            Assignee: John Sherman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The intent is to allow a user to create a table and derive the schema from a 
> user provided parquet file. A secondary goal is to generalize this support so 
> other SerDes/formats could implement the feature easily.
> The proposed syntax is:
> CREATE TABLE <tableName> LIKE FILE <fileFormat> 'path to file';
> Example being:
> {code:java}
> CREATE TABLE like_test_all_types LIKE FILE PARQUET 
> '${system:test.tmp.dir}/test_all_types/000000_0';{code}
> with partitioning
> {code}
> CREATE TABLE like_test_partitioning LIKE FILE PARQUET 
> '${system:test.tmp.dir}/test_all_types/000000_0' PARTITIONED BY (year STRING, 
> month STRING);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to