[
https://issues.apache.org/jira/browse/HIVE-26414?focusedWorklogId=794884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794884
]
ASF GitHub Bot logged work on HIVE-26414:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/22 12:56
Start Date: 25/Jul/22 12:56
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3457:
URL: https://github.com/apache/hive/pull/3457#discussion_r928844426
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManager.java:
##########
@@ -161,7 +161,7 @@ void replTableWriteIdState(String validWriteIdList, String
dbName, String tableN
* @throws LockException if there is no current transaction or the
* transaction has already been committed or aborted.
*/
- void rollbackTxn() throws LockException;
+ void rollbackTxn(Context ctx) throws LockException;
Review Comment:
You mean retain this function -
`void rollbackTxn() throws LockException;`
As well as create a new function -
`void rollbackTxn(Context ctx) throws LockException;` in the interface?
Issue Time Tracking
-------------------
Worklog Id: (was: 794884)
Time Spent: 5h 20m (was: 5h 10m)
> Aborted/Cancelled CTAS operations must initiate cleanup of uncommitted data
> ---------------------------------------------------------------------------
>
> Key: HIVE-26414
> URL: https://issues.apache.org/jira/browse/HIVE-26414
> Project: Hive
> Issue Type: Improvement
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> When a CTAS query fails before creation of table and after writing the data,
> the data is present in the directory and not cleaned up currently by the
> cleaner or any other mechanism currently. This is because the cleaner
> requires a table corresponding to what its cleaning. In order surpass such a
> situation, we can directly pass the relevant information to the cleaner so
> that such uncommitted data is deleted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
