[
https://issues.apache.org/jira/browse/HIVE-22193?focusedWorklogId=796577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796577
]
ASF GitHub Bot logged work on HIVE-22193:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/22 05:13
Start Date: 30/Jul/22 05:13
Worklog Time Spent: 10m
Work Description: nrg4878 commented on code in PR #3386:
URL: https://github.com/apache/hive/pull/3386#discussion_r933752080
##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -438,7 +439,7 @@ public synchronized void init(HiveConf hiveConf) {
}
// Add a shutdown hook for catching SIGTERM & SIGINT
- ShutdownHookManager.addShutdownHook(() -> hiveServer2.stop());
+ ShutdownHookManager.addShutdownHook(() -> graceful_stop());
Review Comment:
if the default is graceful_stop() when you CNTRL-C the HS2 process, should
we decrease the default timeout from 30 mins to something lower? if HS2 does
not have any running queries, I think it would be equivalent to a force
shutdown. But regardless, just thinking out loud.
if there is a long running query, how would one issue a force shutdown ?
Issue Time Tracking
-------------------
Worklog Id: (was: 796577)
Time Spent: 6.5h (was: 6h 20m)
> Graceful Shutdown HiveServer2
> -----------------------------
>
> Key: HIVE-22193
> URL: https://issues.apache.org/jira/browse/HIVE-22193
> Project: Hive
> Issue Type: Improvement
> Components: Server Infrastructure
> Reporter: chenshiyun
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> We have a lot of HiveSever2 servers deployed on production environment (about
> 10 nodes).
> However, if we want to change configuration or add patches, we would have to
> restart all of them one by one. So all the Hive Sql job running on the server
> will be defeated, and there may be some mistakes come up on the jdbc client
> occasionally.
> In the proposed changes, planning to add Graceful Shutdown HiveSever2 method
> to avoid affecting the production environment jobs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
