[ 
https://issues.apache.org/jira/browse/HIVE-26407?focusedWorklogId=796869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796869
 ]

ASF GitHub Bot logged work on HIVE-26407:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Aug/22 12:46
            Start Date: 01/Aug/22 12:46
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3489:
URL: https://github.com/apache/hive/pull/3489#discussion_r934487138


##########
ql/pom.xml:
##########
@@ -793,6 +793,12 @@
       <version>${hamcrest.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-inline</artifactId>
+      <version>${mockito-core.version}</version>

Review Comment:
   please move declaration with version and scope under thee dependency 
management in a root pom





Issue Time Tracking
-------------------

    Worklog Id:     (was: 796869)
    Time Spent: 20m  (was: 10m)

> Do not collect statistics if the compaction fails
> -------------------------------------------------
>
>                 Key: HIVE-26407
>                 URL: https://issues.apache.org/jira/browse/HIVE-26407
>             Project: Hive
>          Issue Type: Test
>          Components: Hive
>            Reporter: Zsolt Miskolczi
>            Assignee: Zsolt Miskolczi
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> It can still compute statistics, even if compaction fails.
> if (computeStats) \{
>   StatsUpdater.gatherStats(ci, conf, runJobAsSelf(ci.runAs) ? ci.runAs : 
> t1.getOwner(),
>           CompactorUtil.getCompactorJobQueueName(conf, ci, t1));
> }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to