[
https://issues.apache.org/jira/browse/HIVE-26448?focusedWorklogId=797927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797927
]
ASF GitHub Bot logged work on HIVE-26448:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/22 10:01
Start Date: 04/Aug/22 10:01
Worklog Time Spent: 10m
Work Description: beliefer opened a new pull request, #3501:
URL: https://github.com/apache/hive/pull/3501
### What changes were proposed in this pull request?
Currently, these method `setV0`, `setV1`, `setV2` of `UnsignedInt128` call
`updateCount` directly.
The `updateCount` of `UnsignedInt128` have a lot `if ... else ...` logic.
In fact, we can improve the code by judge `count` field of `UnsignedInt128`.
### Why are the changes needed?
Improve UnsignedInt128.setV*()
### Does this PR introduce _any_ user-facing change?
'No'.
Just update the inner implementation.
### How was this patch tested?
New test cases.
Issue Time Tracking
-------------------
Worklog Id: (was: 797927)
Remaining Estimate: 0h
Time Spent: 10m
> Improve UnsignedInt128.setV*()
> ------------------------------
>
> Key: HIVE-26448
> URL: https://issues.apache.org/jira/browse/HIVE-26448
> Project: Hive
> Issue Type: Sub-task
> Components: SQL
> Reporter: jiaan.geng
> Priority: Major
> Fix For: 0.13.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, these method setV0, setV1, setV2 of UnsignedInt128 call
> updateCount directly.
> updateCount have a lot if else logic.
> In fact, we can improve the code by judge count field.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
