[
https://issues.apache.org/jira/browse/HIVE-26407?focusedWorklogId=800611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800611
]
ASF GitHub Bot logged work on HIVE-26407:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/22 14:23
Start Date: 15/Aug/22 14:23
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3489:
URL: https://github.com/apache/hive/pull/3489#discussion_r945796938
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -142,65 +139,10 @@ public void run() {
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
this.workerName = getWorkerId();
+ this.statsUpdater = new StatsUpdater();
Review Comment:
you are creating an instance of StatsUpdater per Worker thread. can we use a
single instance here?
Issue Time Tracking
-------------------
Worklog Id: (was: 800611)
Time Spent: 2h 10m (was: 2h)
> Do not collect statistics if the compaction fails
> -------------------------------------------------
>
> Key: HIVE-26407
> URL: https://issues.apache.org/jira/browse/HIVE-26407
> Project: Hive
> Issue Type: Test
> Components: Hive
> Reporter: Zsolt Miskolczi
> Assignee: Zsolt Miskolczi
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It can still compute statistics, even if compaction fails.
> if (computeStats) \{
> StatsUpdater.gatherStats(ci, conf, runJobAsSelf(ci.runAs) ? ci.runAs :
> t1.getOwner(),
> CompactorUtil.getCompactorJobQueueName(conf, ci, t1));
> }
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
