[
https://issues.apache.org/jira/browse/HIVE-26012?focusedWorklogId=800976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800976
]
ASF GitHub Bot logged work on HIVE-26012:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/22 14:12
Start Date: 16/Aug/22 14:12
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #3477:
URL: https://github.com/apache/hive/pull/3477#discussion_r946831412
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1230,74 +1230,79 @@ private void create_database_core(RawStore ms, final
Database db)
Map<String, String> transactionalListenersResponses =
Collections.emptyMap();
try {
firePreEvent(new PreCreateDatabaseEvent(db, this));
- //reinstate location uri for metastore db.
- if (skipAuthorization == true){
- db.setLocationUri(dbExtPath.toString());
- if (dbMgdPath != null) {
- db.setManagedLocationUri(dbMgdPath.toString());
- }
- }
- if (db.getCatalogName() != null && !db.getCatalogName().
- equals(Warehouse.DEFAULT_CATALOG_NAME)) {
- if (!wh.isDir(dbExtPath)) {
- LOG.debug("Creating database path " + dbExtPath);
- if (!wh.mkdirs(dbExtPath)) {
- throw new MetaException("Unable to create database path " +
dbExtPath +
- ", failed to create database " + db.getName());
+
+ //reinstate location uri for metastore db.
Review Comment:
nit: extra spaces
Issue Time Tracking
-------------------
Worklog Id: (was: 800976)
Time Spent: 4h 20m (was: 4h 10m)
> HMS APIs to be enhanced for metadata replication
> ------------------------------------------------
>
> Key: HIVE-26012
> URL: https://issues.apache.org/jira/browse/HIVE-26012
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Affects Versions: 3.1.0
> Reporter: Naveen Gangam
> Assignee: Hongdan Zhu
> Priority: Major
> Labels: pull-request-available
> Attachments: HMS APIs to be enhanced for metadata replication.docx
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> HMS currently has APIs like these that automatically create/delete the
> directories on the associated DFS.
> [create/drop]_database
> [create/drop]_table*
> [add/append/drop]_partition*
> This is expected and should be this way when query processors use this APIs.
> However, when tools that replicate hive metadata use this APIs on the target
> cluster, creating these dirs on target side which cause the replication of
> DFS-snapshots to fail.
> So we if provide an option to bypass this creation of dirs, dfs replications
> will be smoother. In the future we will need to restrict users that can use
> these APIs. So we will have some sort of an authorization policy.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
