[
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=801717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801717
]
ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/22 14:09
Start Date: 18/Aug/22 14:09
Worklog Time Spent: 10m
Work Description: klcopp commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r949159305
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -14214,7 +14214,7 @@ private void validateCreateView()
if (SemanticAnalyzer.DUMMY_TABLE.equals(table.getTableName())) {
continue;
}
- if (!AcidUtils.isTransactionalTable(table)) {
+ if (!AcidUtils.isTransactionalTable(table) &&
!AcidUtils.isNonNativeAcidTable(table)) {
Review Comment:
What does this do?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2966,7 +2971,7 @@ PartitionsResponse get_partitions_req(1:PartitionsRequest
req)
bool submit_for_cleanup(1:CompactionRequest o1, 2:i64 o2, 3:i64 o3) throws
(1:MetaException o1)
void add_dynamic_partitions(1:AddDynamicPartitions rqst) throws
(1:NoSuchTxnException o1, 2:TxnAbortedException o2)
// Deprecated, use find_next_compact2()
- OptionalCompactionInfoStruct find_next_compact(1: string workerId)
throws(1:MetaException o1)
+ OptionalCompactionInfoStruct find_next_compact(1: string workerId, 2: string
poolName) throws(1:MetaException o1)
Review Comment:
Hm, I'm not sure I understand why we need this change if we can use
find_next_compact2?
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -441,6 +441,12 @@ public enum ConfVars {
COMPACTOR_USE_CUSTOM_POOL("metastore.compactor.use.custom.pool",
"hive.compactor.use.custom.pool",
false, "internal usage only
Issue Time Tracking
-------------------
Worklog Id: (was: 801717)
Time Spent: 20m (was: 10m)
> Add priority queueing to compaction
> -----------------------------------
>
> Key: HIVE-26443
> URL: https://issues.apache.org/jira/browse/HIVE-26443
> Project: Hive
> Issue Type: New Feature
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: Pool based compaction queues.docx
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The details can be found in the attached design doc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
