[
https://issues.apache.org/jira/browse/HIVE-26248?focusedWorklogId=802155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802155
]
ASF GitHub Bot logged work on HIVE-26248:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/22 00:08
Start Date: 20/Aug/22 00:08
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3312:
URL: https://github.com/apache/hive/pull/3312#discussion_r950617222
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -1926,7 +1926,7 @@ public void create_dataconnector(final DataConnector
connector)
} catch (NoSuchObjectException e) {
// expected
}
-
+ firePreEvent(new PreCreateDataConnectorEvent(connector, this));
Review Comment:
We are calling firePreevent for PreCreateDataConnectorEvent here and at
L#1887 (create_dataconnector_core api). Also, create_dataconnector_core() API
is a private method and is only being called in this method. So I don't think
we would need this firePreEvent here.
Issue Time Tracking
-------------------
Worklog Id: (was: 802155)
Time Spent: 3h 10m (was: 3h)
> Add data connector authorization on HMS server-side
> ---------------------------------------------------
>
> Key: HIVE-26248
> URL: https://issues.apache.org/jira/browse/HIVE-26248
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2
> Reporter: zhangbutao
> Assignee: zhangbutao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
