[jira] [Work logged] (HIVE-26510) Minor compaction creates empty delta files when no prior delta file exists

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-26510?focusedWorklogId=805440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805440
 ]

ASF GitHub Bot logged work on HIVE-26510:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Sep/22 08:48
            Start Date: 01/Sep/22 08:48
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3568:
URL: https://github.com/apache/hive/pull/3568#discussion_r960387642


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java:
##########
@@ -817,6 +816,7 @@ public void map(WritableComparable key, CompactorInputSplit 
split,
           deleteEventWriter.write(value);
           reporter.progress();
         } else {
+          getWriter(reporter, reader.getObjectInspector(), split.getBucket());

Review Comment:
   could we refactor to:
   ````
           if (sawDeleteRecord && acidOperationalProperties.isSplitUpdate()) {
               getDeleteEventWriter(reporter, reader.getObjectInspector(), 
split.getBucket())
                   .write(value);
             reporter.progress();
           } else {
             getWriter(reporter, reader.getObjectInspector(), split.getBucket())
                 .write(value);
             reporter.progress();
           }
   ````





Issue Time Tracking
-------------------

    Worklog Id:     (was: 805440)
    Time Spent: 20m  (was: 10m)

> Minor compaction creates empty delta files when no prior delta file exists
> --------------------------------------------------------------------------
>
>                 Key: HIVE-26510
>                 URL: https://issues.apache.org/jira/browse/HIVE-26510
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sourabh Badhya
>            Assignee: Sourabh Badhya
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Hive is creating empty delta files after minor compaction even when 0 delta 
> files exists before compaction.
> Steps to reproduce:
> {code:java}
> DROP TABLE IF EXISTS test_major_delete_minor;
> CREATE TABLE test_major_delete_minor (name VARCHAR(50), age TINYINT, 
> num_clicks BIGINT) stored as orc;
> insert into test_major_delete_minor values ('amy', 35, 12341234);
> insert into test_major_delete_minor values ('bob', 66, 1234712348712);
> insert into test_major_delete_minor values ('cal', 21, 431);
> insert into test_major_delete_minor values ('fse', 28, 8456);
> ALTER TABLE test_major_delete_minor  COMPACT 'major';
> DELETE FROM test_major_delete_minor WHERE name='bob';
> DELETE FROM test_major_delete_minor WHERE name='fse';
> ALTER TABLE test_major_delete_minor  COMPACT 'minor'; {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)