[
https://issues.apache.org/jira/browse/HIVE-26500?focusedWorklogId=806627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806627
]
ASF GitHub Bot logged work on HIVE-26500:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/22 08:43
Start Date: 07/Sep/22 08:43
Worklog Time Spent: 10m
Work Description: abstractdog merged PR #3556:
URL: https://github.com/apache/hive/pull/3556
Issue Time Tracking
-------------------
Worklog Id: (was: 806627)
Time Spent: 2h 10m (was: 2h)
> Improve TestHiveMetastore
> -------------------------
>
> Key: HIVE-26500
> URL: https://issues.apache.org/jira/browse/HIVE-26500
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> {code}
> Thread.sleep(5 * 1000); // give HMS time to handle close request
> int numObjectsAfterClose = getJDOPersistanceManagerCacheSize();
> assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
> {code}
> 1. easy fix: assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
> this tells nothing in case of assertionerror:
> {code}
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertTrue(Assert.java:53)
> at
> org.apache.hadoop.hive.metastore.TestHiveMetaStore.testJDOPersistanceManagerCleanup(TestHiveMetaStore.java:3298)
> {code}
> should tell a more informative message with particular values
> 2. harder fix, maybe do it later
> {code}
> Thread.sleep(5 * 1000); // give HMS time to handle close request
> {code}
> sleep is always dangerous, cannot make sure it handled everything that we
> expected
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
