[ 
https://issues.apache.org/jira/browse/HIVE-26488?focusedWorklogId=808559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-808559
 ]

ASF GitHub Bot logged work on HIVE-26488:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Sep/22 08:36
            Start Date: 14/Sep/22 08:36
    Worklog Time Spent: 10m 
      Work Description: ayushtkn commented on code in PR #3538:
URL: https://github.com/apache/hive/pull/3538#discussion_r970498592


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/DDLSemanticAnalyzerFactory.java:
##########
@@ -65,10 +68,12 @@ public interface DDLSemanticAnalyzerCategory {
       new HashMap<>();
 
   static {
-    Set<Class<? extends BaseSemanticAnalyzer>> analyzerClasses1 =
-        new Reflections(DDL_ROOT).getSubTypesOf(BaseSemanticAnalyzer.class);
-    Set<Class<? extends CalcitePlanner>> analyzerClasses2 =
-        new Reflections(DDL_ROOT).getSubTypesOf(CalcitePlanner.class);
+    Set<Class<? extends BaseSemanticAnalyzer>> analyzerClasses1 = new 
Reflections(
+        new ConfigurationBuilder()
+            .setUrls(ClasspathHelper.forPackage(DDL_ROOT)).filterInputsBy(new 
FilterBuilder().includePackage(DDL_ROOT)).setExpandSuperTypes(false)).getSubTypesOf(BaseSemanticAnalyzer.class);
+    Set<Class<? extends CalcitePlanner>> analyzerClasses2 = new Reflections(
+        new ConfigurationBuilder().filterInputsBy(new 
FilterBuilder().includePackage(DDL_ROOT))
+            
.setUrls(ClasspathHelper.forPackage(DDL_ROOT)).setExpandSuperTypes(false)).getSubTypesOf(CalcitePlanner.class);
     Set<Class<? extends BaseSemanticAnalyzer>> analyzerClasses = 
Sets.union(analyzerClasses1, analyzerClasses2);
     for (Class<? extends BaseSemanticAnalyzer> analyzerClass : 
analyzerClasses) {

Review Comment:
   Done





Issue Time Tracking
-------------------

    Worklog Id:     (was: 808559)
    Time Spent: 1h 40m  (was: 1.5h)

> Fix NPE in DDLSemanticAnalyzerFactory during compilation
> --------------------------------------------------------
>
>                 Key: HIVE-26488
>                 URL: https://issues.apache.org/jira/browse/HIVE-26488
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> *Exception Trace:*
> {noformat}
> java.lang.ExceptionInInitializerError
>       at 
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.getInternal(SemanticAnalyzerFactory.java:62)
>       at 
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.get(SemanticAnalyzerFactory.java:41)
>       at org.apache.hadoop.hive.ql.Compiler.analyze(Compiler.java:209)
>       at org.apache.hadoop.hive.ql.Compiler.compile(Compiler.java:106)
>       at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:507)
>       at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:459)
>       at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:424)
>       at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:418)
> {noformat}
> *Cause:*
> {noformat}
> Caused by: java.lang.NullPointerException
>       at 
> org.apache.hadoop.hive.ql.ddl.DDLSemanticAnalyzerFactory.<clinit>(DDLSemanticAnalyzerFactory.java:84)
>       ... 40 more
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to