[
https://issues.apache.org/jira/browse/HIVE-26471?focusedWorklogId=809499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-809499
]
ASF GitHub Bot logged work on HIVE-26471:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/22 11:42
Start Date: 16/Sep/22 11:42
Worklog Time Spent: 10m
Work Description: InvisibleProgrammer commented on code in PR #3521:
URL: https://github.com/apache/hive/pull/3521#discussion_r972929518
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/CompactionMetricData.java:
##########
@@ -148,6 +152,10 @@ Map<String, Long> getStateCount() {
return new HashMap<>(stateCount);
}
+ public Map<String, Integer> getPoolCount() {
+ return new HashMap<>(poolCount);
Review Comment:
I wonder, what is the reason of copying the poolCount map instead of passing
it to the caller?
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/CompactionMetricData.java:
##########
@@ -45,6 +45,8 @@ final class CompactionMetricData {
private Map<String, Long> stateCount;
+ private Map<String, Integer> poolCount;
Review Comment:
I wonder if the counter can be Long or not. I mean, the `CC_ID` column in
the meta-store database is big int. I don't know our usage statistics but I
wonder: it is possible to have so many compaction requests in pool that Integer
is not enough?
Issue Time Tracking
-------------------
Worklog Id: (was: 809499)
Time Spent: 1h 10m (was: 1h)
> New metric for Compaction pooling
> ---------------------------------
>
> Key: HIVE-26471
> URL: https://issues.apache.org/jira/browse/HIVE-26471
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> To be able to properly supervise the pool based compaction, a new metric is
> required:
> Number of 'Initiated' compaction requests per compaction pool.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
