[
https://issues.apache.org/jira/browse/HIVE-14514?focusedWorklogId=811340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811340
]
ASF GitHub Bot logged work on HIVE-14514:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/22 18:24
Start Date: 22/Sep/22 18:24
Worklog Time Spent: 10m
Work Description: ayushtkn commented on PR #3610:
URL: https://github.com/apache/hive/pull/3610#issuecomment-1255392957
AFAIK, we have to wait 24 hrs after the first approval, so that people in
all timezone can have a look.
Will merge it tomorrow
Issue Time Tracking
-------------------
Worklog Id: (was: 811340)
Time Spent: 1h 10m (was: 1h)
> OrcRecordUpdater should clone writerOptions when creating delete event writers
> ------------------------------------------------------------------------------
>
> Key: HIVE-14514
> URL: https://issues.apache.org/jira/browse/HIVE-14514
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 2.2.0
> Reporter: Saket Saurabh
> Assignee: Dmitriy Fingerman
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When split-update is enabled for ACID, OrcRecordUpdater creates two sets of
> writers: one for the insert deltas and one for the delete deltas. The
> deleteEventWriter is initialized with similar writerOptions as the normal
> writer, except that it has a different callback handler. Due to the lack of
> copy constructor/ clone() method in writerOptions, the same writerOptions
> object is mutated to specify a different callback for the delete case.
> Although, this is harmless for now, but it may become a source of confusion
> and possible error in future. The ideal way to fix this would be to create a
> clone() method for writerOptions- however this requires that the parent class
> of WriterOptions in the OrcFile.WriterOptions should implement Cloneable or
> provide a copy constructor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
