[
https://issues.apache.org/jira/browse/HIVE-26320?focusedWorklogId=813742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-813742
]
ASF GitHub Bot logged work on HIVE-26320:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/22 15:33
Start Date: 30/Sep/22 15:33
Worklog Time Spent: 10m
Work Description: jfsii commented on code in PR #3628:
URL: https://github.com/apache/hive/pull/3628#discussion_r984716423
##########
serde/src/java/org/apache/hadoop/hive/serde2/io/HiveBaseCharWritable.java:
##########
@@ -26,10 +26,19 @@
import org.apache.hive.common.util.HiveStringUtils;
public abstract class HiveBaseCharWritable {
- protected Text value = new Text();
+ protected Text value;
protected int charLength = -1;
public HiveBaseCharWritable() {
+ value = new Text();
+ }
+
+ public HiveBaseCharWritable(Text text) {
+ value = text;
+ }
+
+ public HiveBaseCharWritable(byte[] bytes) {
+ value = new Text(bytes);
Review Comment:
Likely no specific reason, it just happened to end up that way. I suppose
that I didn't notice the set method on the Text object and wanted to avoid an
extra allocation.
Issue Time Tracking
-------------------
Worklog Id: (was: 813742)
Time Spent: 3h 50m (was: 3h 40m)
> Incorrect case evaluation for Parquet based table
> -------------------------------------------------
>
> Key: HIVE-26320
> URL: https://issues.apache.org/jira/browse/HIVE-26320
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, Query Planning
> Affects Versions: 4.0.0-alpha-1
> Reporter: Chiran Ravani
> Assignee: John Sherman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Query involving case statement with two or more conditions leads to incorrect
> result for tables with parquet format, The problem is not observed with ORC
> or TextFile.
> *Steps to reproduce*:
> {code:java}
> create external table case_test_parquet(kob varchar(2),enhanced_type_code
> int) stored as parquet;
> insert into case_test_parquet values('BB',18),('BC',18),('AB',18);
> select case when (
> (kob='BB' and enhanced_type_code='18')
> or (kob='BC' and enhanced_type_code='18')
> )
> then 1
> else 0
> end as logic_check
> from case_test_parquet;
> {code}
> Result:
> {code}
> 0
> 0
> 0
> {code}
> Expected result:
> {code}
> 1
> 1
> 0
> {code}
> The problem does not appear when setting hive.optimize.point.lookup=false.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
