[
https://issues.apache.org/jira/browse/HIVE-26596?focusedWorklogId=814393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-814393
]
ASF GitHub Bot logged work on HIVE-26596:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/22 14:33
Start Date: 06/Oct/22 14:33
Worklog Time Spent: 10m
Work Description: rbalamohan commented on code in PR #3646:
URL: https://github.com/apache/hive/pull/3646#discussion_r989129160
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -144,6 +145,12 @@ public static Table createTable(Configuration conf,
Properties props) {
Map<String, String> map = filterIcebergTableProperties(props);
+ // Hive only supports merge-on-read delete mode, it will actually throw an
error if DML operations are attempted on
+ // tables that don't have this (the default is copy-on-write)
+ if ("2".equals(props.get(TableProperties.FORMAT_VERSION))) {
+ map.put(TableProperties.DELETE_MODE, "merge-on-read");
Review Comment:
Will this be deleted when copy-on-write is supported later? If so, it will
be good to add a minor TODO here.
Issue Time Tracking
-------------------
Worklog Id: (was: 814393)
Remaining Estimate: 0h
Time Spent: 10m
> Hive should enforce merge-on-read delete mode is set for Iceberg V2 tables
> --------------------------------------------------------------------------
>
> Key: HIVE-26596
> URL: https://issues.apache.org/jira/browse/HIVE-26596
> Project: Hive
> Issue Type: Improvement
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Hive only implements merge-on-read delete mode with its DML operations on
> Iceberg V2 tables. Should an Iceberg table specify copy-on-write mode, then
> Hive must throw an error for an attempted DML op.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
