[
https://issues.apache.org/jira/browse/HIVE-26539?focusedWorklogId=815079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815079
]
ASF GitHub Bot logged work on HIVE-26539:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/22 02:54
Start Date: 10/Oct/22 02:54
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #3605:
URL: https://github.com/apache/hive/pull/3605#discussion_r990886739
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java:
##########
@@ -228,6 +230,27 @@ public void setConf(Configuration conf) {
public Configuration getConf() {
return configuration;
}
+
+ @Override
+ public com.esotericsoftware.kryo.Registration getRegistration(Class type) {
Review Comment:
I think so, `getRegistration` is place for check whether an unregistered
class is encountered when `registrationRequired` is set to true:
https://github.com/EsotericSoftware/kryo/blob/master/src/com/esotericsoftware/kryo/Kryo.java#L552-L556
However we cannot simply enable `registrationRequired` for UDF
deserialization, as non-transient fields in the UDF are arbitrary, it's
difficult to confine the inputs.
Thank you for the review and comments!
Issue Time Tracking
-------------------
Worklog Id: (was: 815079)
Time Spent: 50m (was: 40m)
> Kryo deserialization improvements
> ---------------------------------
>
> Key: HIVE-26539
> URL: https://issues.apache.org/jira/browse/HIVE-26539
> Project: Hive
> Issue Type: Improvement
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
