[
https://issues.apache.org/jira/browse/HIVE-13353?focusedWorklogId=815601&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815601
]
ASF GitHub Bot logged work on HIVE-13353:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/22 10:05
Start Date: 11/Oct/22 10:05
Worklog Time Spent: 10m
Work Description: rkirtir commented on code in PR #3608:
URL: https://github.com/apache/hive/pull/3608#discussion_r992119900
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsOperation.java:
##########
@@ -39,16 +43,27 @@
* Operation process of showing compactions.
*/
public class ShowCompactionsOperation extends
DDLOperation<ShowCompactionsDesc> {
+
+ static final protected String MAJOR_TYPE = "MAJOR";
+ static final protected String MINOR_TYPE = "MINOR";
+ static final char INITIATED_STATE = 'i';
Review Comment:
done. Added constants in TxnStore and moved methods in TxnUtil
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsOperation.java:
##########
@@ -68,6 +83,71 @@ public int execute() throws HiveException {
return 0;
}
+ private ShowCompactRequest getShowCompactioRequest(ShowCompactionsDesc desc)
throws MetaException, SemanticException {
+ ShowCompactRequest request = new ShowCompactRequest();
+ if (desc.getDbName() == null && desc.getTbName() != null) {
Review Comment:
done
Issue Time Tracking
-------------------
Worklog Id: (was: 815601)
Time Spent: 4.5h (was: 4h 20m)
> SHOW COMPACTIONS should support filtering options
> -------------------------------------------------
>
> Key: HIVE-13353
> URL: https://issues.apache.org/jira/browse/HIVE-13353
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 1.3.0, 2.0.0
> Reporter: Eugene Koifman
> Assignee: KIRTI RUGE
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-13353.01.patch
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Since we now have historical information in SHOW COMPACTIONS the output can
> easily become unwieldy. (e.g. 1000 partitions with 3 lines of history each)
> this is a significant usability issue
> Need to add ability to filter by db/table/partition
> Perhaps would also be useful to filter by status
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
